Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues: ci - close inactive issue with workflow #6053

Merged
merged 2 commits into from
Mar 16, 2024
Merged

Conversation

phymbert
Copy link
Collaborator

@phymbert phymbert requested a review from ggerganov March 14, 2024 12:32
@phymbert phymbert force-pushed the hp/ci/close-issue branch from bf421ac to e36c5c0 Compare March 14, 2024 12:33
@ggerganov ggerganov added the need feedback Testing and feedback with results are needed label Mar 14, 2024
@ggerganov
Copy link
Owner

Let's give it a day to see if there are any concerns about adding this

@ggerganov
Copy link
Owner

One small concern is that when this runs the first time, all watchers of the repo will receive several hundred notifications about stale issues. Not sure if we can do anything about that though

@ngxson
Copy link
Collaborator

ngxson commented Mar 15, 2024

Also @ggerganov should we update the pinned issues and pinned discussions? As some pinned discussions are not very up-to-date.

I also think that some PRs deserve more visibility like #5021 , should we have a place to keep track of them (other than "Hot topics" in readme?)

@ggerganov ggerganov merged commit a56d09a into master Mar 16, 2024
23 checks passed
@phymbert phymbert deleted the hp/ci/close-issue branch March 16, 2024 21:16
@phymbert
Copy link
Collaborator Author

One small concern is that when this runs the first time, all watchers of the repo will receive several hundred notifications about stale issues. Not sure if we can do anything about that though

Finally it stopped after 30 operations per job, so it will progressivly close stale issues. Great:

@ggerganov
Copy link
Owner

Hm, probably better to close them all at once. Otherwise it will spam us every day for a month

hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 1, 2024
* issues: ci - close inactive issue with workflow

* ci: close issue, change workflow schedule time
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 3, 2024
* issues: ci - close inactive issue with workflow

* ci: close issue, change workflow schedule time
@phymbert
Copy link
Collaborator Author

phymbert commented Apr 9, 2024

Just to share that : this last run manages to break/bypass gmail classification ...

Screenshot_20240409_093731_Gmail.jpg

Still 500+ to proceed...
Also some people are complaining:

But still I think this is for the good, in a couple of weeks, it will become BAU.

@slaren
Copy link
Collaborator

slaren commented Apr 9, 2024

Funnily enough, these issues are truly stale: beam search has been implemented for ages and keeping the model in memory to pass it more text is what the server does. It's useless to have thousands of open issues, it just makes developers ignore the list of issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need feedback Testing and feedback with results are needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants